Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iwyu.yml: also run with libc++ [skip ci] #6743

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave firewave force-pushed the iwyu-libcxx branch 4 times, most recently from e1c3dad to dc56aa4 Compare August 30, 2024 17:36
@@ -111,22 +115,32 @@ jobs:
run: |
PWD=$(pwd)
# -isystem/usr/lib/clang/17/include
iwyu_tool -p cmake.output -j $(nproc) -- -w -Xiwyu --max_line_length=1024 -Xiwyu --comment_style=long -Xiwyu --quoted_includes_first -Xiwyu --update_comments > iwyu.log
iwyu_tool -p cmake.output -j $(nproc) -- -w -Xiwyu --max_line_length=1024 -Xiwyu --comment_style=long -Xiwyu --quoted_includes_first -Xiwyu --update_comments -stdlib=${{ matrix.stdlib }} > iwyu.log
Copy link
Collaborator Author

@firewave firewave Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary since it already is specified in the compilation database:

{
  "directory": "/__w/cppcheck/cppcheck/cmake.output/externals/tinyxml2",
  "command": "/usr/bin/clang++ -DCHECK_INTERNAL -DFILESDIR=\\\"/usr/local/share/Cppcheck\\\" -DHAVE_RULES -I/__w/cppcheck/cppcheck/cmake.output/externals/tinyxml2 -I/__w/cppcheck/cppcheck/externals/tinyxml2 -O3 -DNDEBUG -std=gnu++11 -Weverything -O2 -pedantic -Wall -Wextra -Wcast-qual -Wfloat-equal -Wmissing-declarations -Wmissing-format-attribute -Wno-long-long -Wpacked -Wredundant-decls -Wundef -Wno-missing-field-initializers -Wno-missing-braces -Wno-sign-compare -Wno-multichar -Woverloaded-virtual -mllvm -inline-deferral -gdwarf-4 -stdlib=libc++ -Wno-documentation-unknown-command -Wno-unused-exception-parameter -Wno-old-style-cast -Wno-sign-conversion -Wno-shadow-field-in-constructor -Wno-covered-switch-default -Wno-shorten-64-to-32 -Wno-implicit-int-conversion -Wno-double-promotion -Wno-shadow-field -Wno-shadow-uncaptured-local -Wno-implicit-float-conversion -Wno-switch-enum -Wno-float-conversion -Wno-enum-enum-conversion -Wno-date-time -Wno-disabled-macro-expansion -Wno-bitwise-instead-of-logical -Wno-switch-default -Wno-unsafe-buffer-usage -Wno-global-constructors -Wno-exit-time-destructors -Wno-padded -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-four-char-constants -Wno-weak-vtables -U_GLIBCXX_DEBUG -Wno-implicit-fallthrough -Wno-suggest-destructor-override -Wno-zero-as-null-pointer-constant -Wno-format-nonliteral -Wno-inconsistent-missing-destructor-override -o CMakeFiles/tinyxml2_objs.dir/tinyxml2.cpp.o -c /__w/cppcheck/cppcheck/externals/tinyxml2/tinyxml2.cpp",
  "file": "/__w/cppcheck/cppcheck/externals/tinyxml2/tinyxml2.cpp",
  "output": "externals/tinyxml2/CMakeFiles/tinyxml2_objs.dir/tinyxml2.cpp.o"
}

I filed include-what-you-use/include-what-you-use#1605 upstream.

@firewave firewave force-pushed the iwyu-libcxx branch 5 times, most recently from 522da6f to a74098f Compare October 30, 2024 23:19
@firewave
Copy link
Collaborator Author

Successful build with the changes applied: https://github.com/danmar/cppcheck/actions/runs/11603173116.

@firewave firewave changed the title iwyu.yml: also run with libc++ iwyu.yml: also run with libc++ [skip ci] Oct 30, 2024
@firewave firewave marked this pull request as ready for review October 30, 2024 23:27
@firewave
Copy link
Collaborator Author

No feedback in two weeks - merging.

@firewave firewave merged commit 2a24e2a into danmar:main Nov 14, 2024
@firewave firewave deleted the iwyu-libcxx branch November 14, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant