Fixed #13324 (readd the gui.pro for convenience) #7021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@firewave fyi. I think the transition to CMake in release/ci is fine and have no intention to revert any of that. |
You cannot check-pick. Either we have the proper framework so we are sure it is working or we do not have it at all. If you really need this, please maintain it in a fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me it sounds good to use CMake for CI and releases.
This gui.pro file is only meant as a convenience for Qt Creator developers.
It's inconvenient to use CMake because you get all targets in the tree in Qt Creator.