Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueFlow: delayed some code until necessary and added some early outs #7052

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

ValueFlow: delayed some code until necessary and added some early outs #7052

wants to merge 9 commits into from
+38 −28

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
valueflow.cpp: only perform call eval() in parseBinaryIntOp() whe…
70051ae 
…n result is required
@firewave
valueflow.cpp: do not copy values in parseCompareEachInt() until ne…
a12f552 
…eded
@firewave
valueflow.cpp: do not create value in valueFlowIterators() until un…
7f47e88 
…necessary
@firewave
programmemory.cpp: do not copy value in Executor::execute() until n…
270121c 
…ecessary
@firewave
valueflow.cpp: do not create value in valueFlowSameExpressions() un…
a4c41b5 
…til necessary
@firewave
valueflow.cpp: do not perform function calls in minUnsignedValue() …
4b013f2 
…until necessary
@firewave
valueflow.cpp: added some early outs in `ConditionHandler::beforeCond…
511c0aa 
…ition()`
@firewave
programmemory.cpp: do not perform call in `Executor::executeMultiCond…
76b2aef 
…ition()` until necessary
@firewave
valueflow.cpp: added early out in valueFlowConditionExpressions()
9c2a6b4
@firewave
Copy link
Collaborator Author

firewave commented Nov 30, 2024 •
edited
Loading

A first round of local testing showed very small improvements. The CI is also mainly slightly improved with one outlier (but given how much longer it takes that might just be more visible noise).

before

Check time: cli/cmdlineparser.cpp: 1006.88s
[...]
Check time: lib/checkio.cpp: 208.024s
[...]
Check time: lib/vf_settokenvalue.cpp: 35.0221s
[...]
Check time: lib/tokenize.cpp: 265.461s

after

Check time: cli/cmdlineparser.cpp: 1018.34s
[...]
Check time: lib/checkio.cpp: 202.278s
[...]
Check time: lib/vf_settokenvalue.cpp: 32.4819s
[...]
Check time: lib/tokenize.cpp: 258.276s

@firewave firewave marked this pull request as ready for review November 30, 2024 14:34
@firewave firewave changed the title ValueFlow: delayed some function calls until necessary and added some early outs ValueFlow: delayed some code until necessary and added some early outs Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@firewave