Skip to content

Fix #13364 (CI: Use Cppcheck Premium 24.11.0 in cppcheckpremium.yml) #7054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 1 commit into from
Dec 1, 2024
Merged

Fix #13364 (CI: Use Cppcheck Premium 24.11.0 in cppcheckpremium.yml) #7054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/cppcheck-premium.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,21 @@ jobs:
run: |
premium_version=${{ inputs.premium_version }}
if [ -z $premium_version ]; then
premium_version=24.9.0.1
premium_version=24.11.0
Copy link
Contributor

@artemis-gerrard-oxa artemis-gerrard-oxa Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered adding a /latest/ link?

Pro:

  • code says what it means; use the latest

Con:

  • external change can effect CI (i.e. update posted, CI now fails)

Copy link
Owner Author

@danmar danmar Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the explicit version, I don't have the intention to always run latest Cppcheck Premium it's just that there has been important problems with older releases that I wanted to avoid so I have used latest in practice.. An important Pro with an explicit version is that it will be seen easily later (for instance 10 years from now) which exact version we used when checking a particular cppcheck-release.

#wget https://files.cppchecksolutions.com/devdrop/cppcheckpremium-$premium_version-amd64.tar.gz -O cppcheckpremium.tar.gz
wget https://files.cppchecksolutions.com/$premium_version/ubuntu-24.04/cppcheckpremium-$premium_version-amd64.tar.gz -O cppcheckpremium.tar.gz
else
wget https://files.cppchecksolutions.com/$premium_version/ubuntu-24.04/cppcheckpremium-$premium_version-amd64.tar.gz -O cppcheckpremium.tar.gz
fi
tar xvzf cppcheckpremium.tar.gz
tar xzf cppcheckpremium.tar.gz
mv cppcheckpremium-$premium_version cppcheckpremium

- name: Generate a license file
run: |
echo cppcheck > cppcheck.lic
echo 241231 >> cppcheck.lic
echo 251231 >> cppcheck.lic
echo 80000 >> cppcheck.lic
echo 53b72a908d7aeeee >> cppcheck.lic
echo 4f8dc8e7c8bb288f >> cppcheck.lic
echo path:lib >> cppcheck.lic

- name: Check
Expand Down
Loading