Fix #13401 (cppcheck-addon-ctu-file-list filename should be unique for each process) #7082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2024
Owner
Author
|
This is not tested. I am not sure how we can test it effectively and elegantly. |
Collaborator
#6696 will do that. After all it exposed the issue. |
firewave
reviewed
Dec 8, 2024
… Processing a single ctu-info file does not require a filelist
Co-authored-by: Oliver Stöneberg <firewave@users.noreply.github.com>
Owner
Author
Thanks I agree. |
Collaborator
|
A much cleaner solution would be to pipe that data into the process and read it from stdin. That would eliminate the usage of the temporary file and any possibility of a race condition. |
Owner
Author
yes 👍 |
Owner
Author
|
I created ticket https://trac.cppcheck.net/ticket/13404 to update the interface. |
danmar
added a commit
that referenced
this pull request
Dec 10, 2024
…r each process) (#7082) Co-authored-by: Oliver Stöneberg <firewave@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.