removed emptyString and its remaining usage
#7296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
firewave
force-pushed
the
emptystring-z
branch
4 times, most recently
from
5c240c0 to
5ebf215
Compare
firewave
force-pushed
the
emptystring-z
branch
4 times, most recently
from
6d5b102 to
9dc139b
Compare
firewave
force-pushed
the
emptystring-z
branch
from
c0bc1e9 to
2064919
Compare
firewave
force-pushed
the
emptystring-z
branch
3 times, most recently
from
bf04e79 to
cd074a9
Compare
|
#7772 addresses part of the regression. The rest seems mostly stemming from the default parameters for |
firewave
force-pushed
the
emptystring-z
branch
from
cd074a9 to
22cda74
Compare
firewave
force-pushed
the
emptystring-z
branch
3 times, most recently
from
9bf8161 to
f2458aa
Compare
|
#7813 added more mitigations for the regressions from this change. But I still see a minor regression I need to look into. |
firewave
force-pushed
the
emptystring-z
branch
from
f2458aa to
305403b
Compare
firewave
force-pushed
the
emptystring-z
branch
3 times, most recently
from
812cbf1 to
ad89c58
Compare
|
The remaining regression just seems to be related to slight differences in the determined Ir count for very hot calls. I see no increase in calls. |
firewave
force-pushed
the
emptystring-z
branch
from
ad89c58 to
40c6ac1
Compare
|
danmar
reviewed
Oct 25, 2025
If you read my comments above you will see that I addressed the regressions it caused and that it hasn't slowed down. |
danmar
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.