improved determination if application is Premium / added TODOs #7346
+165
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Mar 1, 2025
Comment on lines
+1634
to
+1644
| const std::string manualUrl(premium ? | ||
| "https://files.cppchecksolutions.com/manual.pdf" : | ||
| "https://cppcheck.sourceforge.io/manual.pdf"); |
There was a problem hiding this comment.
These were switched.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This is in preparation of avoiding It also gets rid of loading the |
firewave
commented
Mar 1, 2025
Comment on lines
-29
to
+31
| "about": "NAME", | ||
| "safety": true | ||
| "about": "NAME" |
There was a problem hiding this comment.
This test was based on the behavior that is loaded cppcheck.cfg first and being overriden by the CLI. But that is not how it was initially implemented. That behavior changed when the double loading was introduced in #5760.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.