-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix #13737 (GUI: should not timeout when premiumaddon takes more than 30 seconds) #7418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI is fixed - please rebase. |
Thanks! |
firewave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please separate the crash fix into a different PR.
|
And did you intend to update the translation files? |
the ts files are updated behind my back whenever I compile the gui. if I am not supposed to commit that then it should be removed from the compilation. |
ok sure. |
We had that discussion many times before and I am still waiting on external feedback in #7020 to finally address this. |
basically I think it would make sense to go ahead with 7020 if that means we won't get ts updates every time we touch the gui. feel free to continue without the feedback. |
Alright. I will do a couple of more tests first so we do not miss something obvious. |
|
ticket for assertion failure: https://trac.cppcheck.net/ticket/13749 |
No description provided.