Skip to content

Conversation

@danmar
Copy link
Owner

@danmar danmar commented Apr 1, 2025

No description provided.

@firewave
Copy link
Collaborator

firewave commented Apr 2, 2025

CI is fixed - please rebase.

@danmar
Copy link
Owner Author

danmar commented Apr 2, 2025

CI is fixed - please rebase.

Thanks!

Copy link
Collaborator

@firewave firewave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the crash fix into a different PR.

@firewave
Copy link
Collaborator

firewave commented Apr 2, 2025

And did you intend to update the translation files?

@danmar
Copy link
Owner Author

danmar commented Apr 3, 2025

And did you intend to update the translation files?

the ts files are updated behind my back whenever I compile the gui. if I am not supposed to commit that then it should be removed from the compilation.

@danmar
Copy link
Owner Author

danmar commented Apr 3, 2025

Please separate the crash fix into a different PR.

ok sure.

@firewave
Copy link
Collaborator

firewave commented Apr 3, 2025

the ts files are updated behind my back whenever I compile the gui. if I am not supposed to commit that then it should be removed from the compilation.

We had that discussion many times before and I am still waiting on external feedback in #7020 to finally address this.

@danmar
Copy link
Owner Author

danmar commented Apr 3, 2025

We had that discussion many times before and I am still waiting on external feedback in #7020 to finally address this

basically I think it would make sense to go ahead with 7020 if that means we won't get ts updates every time we touch the gui. feel free to continue without the feedback.

@firewave
Copy link
Collaborator

firewave commented Apr 3, 2025

basically I think it would make sense to go ahead with 7020 if that means we won't get ts updates every time we touch the gui. feel free to continue without the feedback.

Alright. I will do a couple of more tests first so we do not miss something obvious.

@danmar
Copy link
Owner Author

danmar commented Apr 3, 2025

ticket for assertion failure: https://trac.cppcheck.net/ticket/13749
PR: #7428

@danmar danmar merged commit fd9304e into danmar:main Apr 3, 2025
60 checks passed
@danmar danmar deleted the fix-13737 branch April 3, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants