Skip to content

Conversation

@firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

Like previous changes this messes up the expected output of TODO test cases a bit.

Speaking of those. I wonder if we should file tickets for all TODO tests. Doing that would make them actually visible and we would have proper triage of them and such.

@firewave firewave marked this pull request as draft April 28, 2025 09:46
const std::string code("#error hello world!\n");
(void)PreprocessorHelper::getcode(settings, *this, code, "X", "test.c");
ASSERT_EQUALS("[test.c:1]: (error) #error hello world!\n", errout_str());
ASSERT_EQUALS("[test.c:1:0]: (error) #error hello world! [preprocessorErrorDirective]\n", errout_str());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing column only occurs in the tests. It is present when using the CLI.

"}\n",
"");
ASSERT_EQUALS("[test.cpp:1]: (information) Unmatched suppression: uninitvar\n", errout_str());
ASSERT_EQUALS("[test.cpp:1:0]: (information) Unmatched suppression: uninitvar [unmatchedSuppression]\n", errout_str());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@firewave firewave marked this pull request as ready for review April 28, 2025 10:02
@chrchr-github chrchr-github merged commit 88ef81e into danmar:main May 2, 2025
53 checks passed
@firewave firewave deleted the testrunner-id-zzz branch May 2, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants