Fix #13831 (do not execute misra.py in cppcheck premium when --premium=misra-c-.. options are used) #7506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #13831 by preventing the execution of misra.py in cppcheck premium mode when misra-c options are used.
- In gui/mainwindow.cpp, the misra addon is skipped during addon processing when cppcheck premium mode is active.
- In cli/cmdlineparser.cpp, the code that previously added the misra addon based on specific premium arguments has been removed.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gui/mainwindow.cpp | Skips the misra addon execution when cppcheck premium is active. |
| cli/cmdlineparser.cpp | Removes the insertion of the misra addon for specific premium args. |
…m=misra-c-.. options are used)
Collaborator
|
LGTM 👍 |
ludviggunne
reviewed
May 11, 2025
| break; | ||
| case ReportType::misraC: | ||
| if (errId.rfind("misra-c20", 0) == 0) | ||
| if (errId.rfind("misra-c20", 0) == 0 || errId.rfind("premium-misra-c-20", 0) == 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.