Skip to content

Fix #13848 FP uninitStructMember with overloaded operator>> #7549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
May 27, 2025
Merged

Fix #13848 FP uninitStructMember with overloaded operator>> #7549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0642360
Update checkuninitvar.cpp
chrchr-github May 26, 2025
19a94e9
Update testuninitvar.cpp
chrchr-github May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/checkuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,9 @@ bool CheckUninitVar::checkScopeForVariable(const Token *tok, const Variable& var


if (!membervar.empty()) {
if (mTokenizer->isCPP() && Token::simpleMatch(tok->astParent(), ">>"))
return true;

if (isMemberVariableAssignment(tok, membervar)) {
checkRhs(tok, var, *alloc, number_of_if, membervar);
return true;
Expand Down
8 changes: 8 additions & 0 deletions test/testuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4987,6 +4987,14 @@ class TestUninitVar : public TestFixture {
" return s.i;\n"
"}\n");
ASSERT_EQUALS("", errout_str());

checkUninitVar("struct S { int a; };\n" // #13848
"int f(std::istream& is) {\n"
" S s;\n"
" is >> s;\n"
" return s.a;\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void uninitvar2_while() {
Expand Down
Loading