Skip to content

Fix #13986 (GUI: thread count configuration) #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glankk merged 2 commits into from
Jul 11, 2025
Merged

Fix #13986 (GUI: thread count configuration) #7664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
990b16a
Add max thread count
glankk Jul 11, 2025
966fe1f
Change job count validation mechanism
glankk Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions gui/settings.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,9 @@
<height>20</height>
</size>
</property>
<property name="inputMask">
<string notr="true">009</string>
</property>
<property name="text">
<string notr="true"/>
</property>
<property name="maxLength">
<number>3</number>
</property>
<property name="alignment">
<set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
</property>
Expand All @@ -82,12 +76,12 @@
<item>
<widget class="QLabel" name="label_3">
<property name="text">
<string>Ideal count:</string>
<string>Max count:</string>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="mLblIdealThreads">
<widget class="QLabel" name="mLblMaxThreads">
<property name="text">
<string notr="true">TextLabel</string>
</property>
Expand Down
17 changes: 6 additions & 11 deletions gui/settingsdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ SettingsDialog::SettingsDialog(ApplicationList *list,
QSettings settings;
mTempApplications->copy(list);

int maxjobs = QThread::idealThreadCount();

mUI->mJobs->setText(settings.value(SETTINGS_CHECK_THREADS, 1).toString());
mUI->mJobs->setValidator(new QIntValidator(1, maxjobs, this));
mUI->mForce->setCheckState(boolToCheckState(settings.value(SETTINGS_CHECK_FORCE, false).toBool()));
mUI->mShowFullPath->setCheckState(boolToCheckState(settings.value(SETTINGS_SHOW_FULL_PATH, false).toBool()));
mUI->mShowNoErrorsMessage->setCheckState(boolToCheckState(settings.value(SETTINGS_SHOW_NO_ERRORS, false).toBool()));
Expand Down Expand Up @@ -119,11 +122,7 @@ SettingsDialog::SettingsDialog(ApplicationList *list,
mUI->mListWidget->setSortingEnabled(false);
populateApplicationList();

const int count = QThread::idealThreadCount();
if (count != -1)
mUI->mLblIdealThreads->setText(QString::number(count));
else
mUI->mLblIdealThreads->setText(tr("N/A"));
mUI->mLblMaxThreads->setText(QString::number(maxjobs));

loadSettings();
initTranslationsList();
Expand Down Expand Up @@ -179,13 +178,9 @@ void SettingsDialog::saveSettings() const

void SettingsDialog::saveSettingValues() const
{
int jobs = mUI->mJobs->text().toInt();
if (jobs <= 0) {
jobs = 1;
}

QSettings settings;
settings.setValue(SETTINGS_CHECK_THREADS, jobs);
if (mUI->mJobs->hasAcceptableInput())
settings.setValue(SETTINGS_CHECK_THREADS, mUI->mJobs->text().toInt());
saveCheckboxValue(&settings, mUI->mForce, SETTINGS_CHECK_FORCE);
saveCheckboxValue(&settings, mUI->mSaveAllErrors, SETTINGS_SAVE_ALL_ERRORS);
saveCheckboxValue(&settings, mUI->mSaveFullPath, SETTINGS_SAVE_FULL_PATH);
Expand Down