Make isValidGlobPattern recognize **
#7682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjoel
changed the title
**
danmar
approved these changes
Jul 19, 2025
Owner
|
@mrjoel Thank you! what name would you like that I add in the AUTHORS file? |
danmar
reviewed
Jul 19, 2025
Contributor
Author
|
Pushed updated commit with AUTHORS entry |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7645 added support for
**matching path separators, but didn't updateisValidGlobPatternfor--suppressto enable it.This also updates test cases and makes
isValidGlobPatternmore correct and robust overall. In particular multiple consecutive?for a glob is absolutely valid and frequently useful to ensure exactly or at least some number of characters.