Fixed #14129 (false positive: unusedPrivateFunction with __attribute__((unused))) #7916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I will merge #7917 before I merge this PR. This PR should be extended.. |
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes false positive warnings for unused private functions when they are marked with the __attribute__((unused)) attribute. The change extends the existing logic that handles [[maybe_unused]] to also recognize GCC's __attribute__((unused)) attribute.
Key Changes:
- Extended the check for attribute-marked private functions to include
__attribute__((unused))in addition to[[maybe_unused]] - Added test cases covering both inline and out-of-line function definitions with the unused attribute
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/checkclass.cpp | Updated privateFunctions() to skip functions marked with __attribute__((unused)) |
| test/testunusedprivfunc.cpp | Added test case attributeUnused() with coverage for both inline and out-of-line definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.