Fix #14286 : Add correct column number to tokens of enum in dump file #7974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
reviewed
Nov 20, 2025
swasti16
force-pushed
the
swasti/add_correct_column_for_enum
branch
from
21b3cac to
84595f8
Compare
|
danmar
reviewed
Nov 22, 2025
| tokenizer.tokenize(code); | ||
| const Token* tok = Token::findsimplematch(tokenizer.tokens(), "static"); | ||
| ASSERT(tok); | ||
| ASSERT_EQUALS(tok->column(), 0); |
Owner
There was a problem hiding this comment.
I would suggest that we try to write a proper column value here. It would be shaky for premiumaddon to warn about static whenever column is 0 => since it is not known why it is 0.
danmar
reviewed
Nov 22, 2025
| } | ||
|
|
||
| void simplifyEnum2() { | ||
| const char code[] = "enum static E {A,B} ab;"; |
Owner
There was a problem hiding this comment.
hmm this code is not valid. the enum name must be placed directly after the enum token. An alternative can be:
enum E {A,B} static ab;
or:
enum E {A,B};
enum E static ab;
btw.. I am not sure if we really need to move the static keyword in Cppcheck we could keep the token order. But probably this is a bigger task than just setting the column numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.