Support Django serialization framework, and dumpdata/loaddata #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2018 16:48
Fake models do not play nice with the django serializer framework.
This required adding BaseField.value_to_string() and BaseField.to_python() methods.
danni
approved these changes
Mar 5, 2018
postgres_composite_types/__init__.py
Outdated
| # is called with a string, assume it was produced by value_to_string | ||
| # and decode it | ||
| if isinstance(value, str): | ||
| value = json.loads(value) |
There was a problem hiding this comment.
I think we need to handle the possibility of this choking, since who knows what random thing we got pointed at. If we can't parse it let's let our super have a go.
There was a problem hiding this comment.
Good catch, but looking at how the rest of Django handles this case, raising a ValidationError on bad data in to_python is the accepted solution. I'll go do that.
mx-moth
force-pushed
the
feature/serialization
branch
from
0dca15f to
4f368f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required adding BaseField.value_to_string() and BaseField.to_python() methods.
django_fake_modeldoes not play nice with the serialization framework, so this had to be dropped in favour of using real models.Fixes #17