🔧 fix: Bookmark Order Adjustment When Moving Up (#3634)

danny-avila · Aug 17, 2024 · a2e85eb · a2e85eb
1 parent 31d7e9f
commit a2e85eb
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/api/models/ConversationTag.js b/api/models/ConversationTag.js
@@ -133,14 +133,21 @@ const adjustPositions = async (user, oldPosition, newPosition) => {
   }
 
   const update = oldPosition < newPosition ? { $inc: { position: -1 } } : { $inc: { position: 1 } };
+  const position =
+    oldPosition < newPosition
+      ? {
+          $gt: Math.min(oldPosition, newPosition),
+          $lte: Math.max(oldPosition, newPosition),
+        }
+      : {
+          $gte: Math.min(oldPosition, newPosition),
+          $lt: Math.max(oldPosition, newPosition),
+        };
 
   await ConversationTag.updateMany(
     {
       user,
-      position: {
-        $gt: Math.min(oldPosition, newPosition),
-        $lte: Math.max(oldPosition, newPosition),
-      },
+      position,
     },
     update,
   );