Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localization): add Traditional Chinese language support #1006

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

goodair220917
Copy link
Contributor

@goodair220917 goodair220917 commented Sep 27, 2023

Summary

Adding Traditional Chinese translation for most of the texts. 3 original translation values of "Show Agent Setting", "Show Completion Setting" and "Plugins" can't be find in Eng.tsx for translating so these are left as English translation, this issue is also found in other translations available in LibreChat now.

Change Type

  • New feature (non-breaking change which adds functionality)

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

  1. Open Setting menu
  2. Select 繁體中文 as the language
  3. Done

Test Configuration:

  • Language: Traditional Chinese

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

Copy link
Collaborator

@berry-13 berry-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add "traditional Chinese" (in your language) to the English translation. It should look something like this:

com_nav_lang_traditionalchinese: '繁體中文'

client/src/localization/languages/ZhTraditional.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@berry-13 berry-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@danny-avila danny-avila merged commit 3137f46 into danny-avila:main Oct 3, 2023
2 checks passed
wingeva1986 added a commit to wingeva1986/chatgpt-clone that referenced this pull request Oct 9, 2023
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
…vila#1006)

* Update Translation.tsx

* TC Translation File Upload

* Update General.tsx

* Update Eng.tsx

* Update ZhTraditional.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants