Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force navigation to /chat/new on endpoint change and conversation deletions #1141

Merged
merged 1 commit into from
Nov 5, 2023
Merged

fix: force navigation to /chat/new on endpoint change and conversation deletions #1141

merged 1 commit into from
Nov 5, 2023

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Nov 4, 2023 •
edited
Loading

Summary

Title. There was a bug where changing endpoint or deleting all/current convo from an existing conversation would correctly clear the convo but not the message view.

This update leverages use of OnSuccess handler from react query to fulfill the expected change from query context. This is an improvement over useEffect which can have unexpected behavior especially with its dependencies array

Also removed ClearConvos component from Settings as is no longer being used, even though I did update the logic as above for it, too.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

existing tests pass, unexpected behavior is no longer observed

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila merged commit a2ee575 into main Nov 5, 2023
2 checks passed
@danny-avila danny-avila deleted the navigate-new branch November 5, 2023 00:33
ywkim added a commit to ywkim/LibreChat that referenced this pull request Nov 19, 2023
@ywkim
Merge 'v0.6.1'
2914e42 
Squashed commit of the following:

commit adbeb46
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Thu Nov 16 08:53:09 2023 -0500

    ✨ v0.6.1 (danny-avila#1189)

commit 9ad47b6
Author: Marco Beretta <81851188+Berry-13@users.noreply.github.com>
Date:   Thu Nov 16 14:42:03 2023 +0100

    style: update graphics (danny-avila#1138)

    * style: update new icon and NavLinks scale

    * style: new username update

    * refactor(Dropdown); style: general settings

    * style(Dropdown); adjust theme

    * style: dropdown and settings text

    * fix(Dropdown) system theme not working

    * style: topbar sticky; fix: general's menu settings transparent with light theme

    * fix(SubmitButton) stop generate button

    * fix: user_provided dialog for new dropdown

    * fix: TS error 'display'

    * fix(EditPresetDialog): for new dropdown

    * style: added green send button

    * converted textchat in tsx

    * style(SubmitButton): tooltip

    * test: fixed ThemeSelector and LangSelector

    * removed transition-opacity

    * fix all tests

    * removed empty cn call

    * chore: Update General.tsx to add Arabic option

    ---------

    Co-authored-by: Danny Avila <110412045+danny-avila@users.noreply.github.com>

commit 8b28fdf
Author: Z1xus <40185941+Z1xus@users.noreply.github.com>
Date:   Thu Nov 16 14:35:18 2023 +0100

    style: update symbols for the next/previous page buttons to make navigation more intuitive (danny-avila#1182)

commit 1ec8e53
Author: QuitCool <129384417+QuitCool@users.noreply.github.com>
Date:   Thu Nov 16 15:34:26 2023 +0200

    🌐: Add Arabic Translations (danny-avila#1180)

    * 🌐: Add Arabic Translations

    * 🌐: Add Arabic Translations (Updated)

commit 405be4b
Author: Fuegovic <32828263+fuegovic@users.noreply.github.com>
Date:   Wed Nov 15 19:17:40 2023 -0500

    fix: .env.example (danny-avila#1185)

    Comment out `UID` and `GID` by default in the .env.example file

commit b171369
Author: Fuegovic <32828263+fuegovic@users.noreply.github.com>
Date:   Wed Nov 15 07:29:47 2023 -0500

    🌍: French translation - Update (danny-avila#1176)

commit ddb42b2
Author: Marco Beretta <81851188+Berry-13@users.noreply.github.com>
Date:   Wed Nov 15 13:29:33 2023 +0100

    added com_ui_stop in italian (danny-avila#1175)

commit 037ea8c
Author: USAGI <124278082+snekkenull@users.noreply.github.com>
Date:   Wed Nov 15 20:29:11 2023 +0800

    Fix: style and translation issues (danny-avila#1172)

    * Update Chinese Translation

    * Update

    * Update

    * Update Anthropic UI

commit e383ecb
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Nov 13 11:17:43 2023 -0500

    chore: bump langchain (danny-avila#1174)

commit c7205c9
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Nov 13 11:05:59 2023 -0500

    feat: Add DALL-E reverse proxy settings and handle errors in image generation (danny-avila#1173)

    * feat: Add DALL-E reverse proxy settings and handle errors in image generation

    * fix(ci): avoid importing extra utilities

commit 25402fd
Author: Fuegovic <32828263+fuegovic@users.noreply.github.com>
Date:   Sun Nov 12 20:49:41 2023 -0500

    doc fix: license ⚖️ (danny-avila#1171)

    * add: License

    * Delete .github/LICENSE.md

commit 216f6da
Author: MACHINSOFT <110278369+machinsoft@users.noreply.github.com>
Date:   Mon Nov 13 04:49:12 2023 +0300

    🌐: Add Russian Translations (danny-avila#1169)

    * Add translation for the button and some elements.

    * Make changes for tests.

commit cbfe47a
Author: eniyiweb <51748469+eniyiweb@users.noreply.github.com>
Date:   Mon Nov 13 04:49:02 2023 +0300

    🌐: Turkish translations (danny-avila#1168)

    * Language translation: Turkish translation

    * Language translation: Turkish translation

commit e5e04c1
Author: USAGI <124278082+snekkenull@users.noreply.github.com>
Date:   Mon Nov 13 09:48:34 2023 +0800

    🌐: Update simplified Chinese translation (danny-avila#1152)

    * Completing simplified Chinese translations

    * Update

    * Update CN translation.

commit 5d95433
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Sun Nov 12 00:44:46 2023 -0500

    chore: remove jose as Bun now supports JWT 🍞 (danny-avila#1167)

    * chore: remove jose as Bun now supports JWT

    * chore: npm audit

commit 9ca84ed
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Fri Nov 10 10:33:56 2023 -0500

    fix(openai/completions): use old method for instruct/davinci/text gen models (danny-avila#1166)

commit d5259e1
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Fri Nov 10 09:58:17 2023 -0500

    feat(OpenAIClient): AZURE_USE_MODEL_AS_DEPLOYMENT_NAME, AZURE_OPENAI_DEFAULT_MODEL (danny-avila#1165)

    * feat(OpenAIClient): AZURE_USE_MODEL_AS_DEPLOYMENT_NAME, AZURE_OPENAI_DEFAULT_MODEL

    * ci: fix initializeClient test

commit 9d100ec
Author: Cfomodz <david.ashby.lds@gmail.com>
Date:   Fri Nov 10 07:41:18 2023 -0500

    docs: Update heroku.md 📄 (danny-avila#1160)

    * Update heroku.md

    Copying the config/install.js expected by RUN npm ci
    Heroku CLI would not take the push without this and errored out consistently due to the expected file being missing.

commit efe057e
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Thu Nov 9 14:32:03 2023 -0500

    fix: correctly pass modelsData to newConversation, also prevent navigation in this case (danny-avila#1162)

commit 5ab9802
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Thu Nov 9 14:04:36 2023 -0500

    fix(OpenAIClient): use official SDK to identify client and avoid false Rate Limit Error (danny-avila#1161)

    * chore: add eslint ignore unused var pattern

    * feat: add extractBaseURL helper for valid OpenAI reverse proxies, with tests

    * feat(OpenAIClient): add new chatCompletion using official OpenAI node SDK

    * fix(ci): revert change to FORCE_PROMPT condition

commit ed3d7c9
Author: Fuegovic <32828263+fuegovic@users.noreply.github.com>
Date:   Wed Nov 8 13:13:10 2023 -0500

    docs: Update docker_compose_install.md 📚(danny-avila#1153)

    * Update docker_compose_install.md

    add instruction to stop the container

    * Update docker_compose_install.md

    ---------

    Co-authored-by: Danny Avila <110412045+danny-avila@users.noreply.github.com>

commit 9d565ec
Author: Jacob Root <me@rooty.dev>
Date:   Wed Nov 8 04:54:50 2023 -0800

    docs: manual user creation 📖 (danny-avila#1151)

commit 43d7a75
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Tue Nov 7 18:52:23 2023 -0500

    feat: allow config of DALL-E-3 System Prompt via env 🎨 (danny-avila#1150)

commit 4f3b667
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Nov 6 20:07:01 2023 -0500

    refactor: condense dall-e instructions, add `style` parameter (danny-avila#1148)

commit 3a38b4b
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Nov 6 19:45:59 2023 -0500

    feat: DALL-E-3 support 🎨 (danny-avila#1147)

    * feat: DALL-E-3 support

    * fix(ci): lock-in openai dependency for types used in data-provider

commit 48c087c
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Nov 6 15:26:16 2023 -0500

    chore: add token rate support for 11/06 models (danny-avila#1146)

    * chore: update model rates with 11/06 rates

    * chore: add new models to env.example for OPENAI_MODELS

    * chore: reference actual maxTokensMap in ci tests

commit 4b63eb5
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Nov 6 14:42:20 2023 -0500

    fix: correct conditional statement in ModelService.js (danny-avila#1145)

commit 5f3ecef
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Nov 6 09:19:43 2023 -0500

    fix(config/scripts): Enhance User Creation and Ban Handling, Standardize Imports (danny-avila#1144)

    * chore: use relative imports for scripts

    * fix(create-user): newUser.save() now properly awaited, double-check user creation, use relative imports, catch exception

    * fix(ban-user): catch exception, handle case where IP is undefined, proper check of user ban on login

commit a2ee575
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Sat Nov 4 20:33:24 2023 -0400

    fix: force navigation to /chat/new on endpoint change and conversation deletions (danny-avila#1141)

commit 0886441
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Sat Nov 4 15:03:31 2023 -0400

    feat(azureOpenAI): Allow Switching Deployment Name by Model Name (danny-avila#1137)

    * feat(azureOpenAI): allow switching deployment name by model name

    * ci: add unit tests and throw error on no api key provided to avoid API call

    * fix(gptPlugins/initializeClient): check if azure is enabled; ci: add unit tests for gptPlugins/initializeClient

    * fix(ci): fix expected error message for partial regex match:  unexpected token

commit a7b5639
Author: Marco Beretta <81851188+Berry-13@users.noreply.github.com>
Date:   Sat Nov 4 16:38:58 2023 +0100

    feat: ban-user command (danny-avila#1121)

    * feat: ban-user command

    * clean up code

    * added duration

    * fix(package-lock) revert commit

commit 3414888
Author: Marco Beretta <81851188+Berry-13@users.noreply.github.com>
Date:   Fri Nov 3 00:04:51 2023 +0100

    Update windows_install.md (danny-avila#1132)

commit c11fbde
Author: ngoctuanai <128912789+chokiproai@users.noreply.github.com>
Date:   Fri Nov 3 04:37:40 2023 +0700

    🌐: Vietnamese translation (danny-avila#1129)

    * Create vi.tsx

    * Rename vi.tsx to Vi.tsx

    * Update Translation.tsx

    * Update General.tsx

    * Update Vi.tsx

    * Update Translation.tsx

    * Update Vi.tsx

    * Create ViTraditional.tsx

    * Update Translation.tsx

    * Delete client/src/localization/languages/ViTraditional.tsx

    * Update Vi.tsx

    * fix and clean up

    ---------

    Co-authored-by: Marco Beretta <81851188+Berry-13@users.noreply.github.com>

commit 9a31df0
Author: Raí <140329135+itzraiss@users.noreply.github.com>
Date:   Wed Nov 1 09:01:38 2023 -0300

    🌐: Update Brasil translation for general settings (danny-avila#1126)

commit b031dea
Author: Super12138 <70494801+Super12138@users.noreply.github.com>
Date:   Mon Oct 30 22:05:20 2023 +0800

    🌐: Update Chinese translation (danny-avila#1115)

    * Update Chinese translation

    * Fix bug

    * Add new string in Chinese String

    * Update Chinese translation and add more strings

commit 9f5d77e
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Oct 30 10:00:20 2023 -0400

    feat(useToastContext): add useContext hook for simpler use (danny-avila#1125)

commit 8f328ec
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Oct 30 09:41:07 2023 -0400

    feat(Tx): Add timestamps to transaction schema (danny-avila#1123)

commit af69763
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Sun Oct 29 15:36:00 2023 -0400

    refactor(addImages): use in functions agent response and assure generated images are included in the response (danny-avila#1120)

commit 5c1e44e
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Sun Oct 29 13:20:30 2023 -0400

    feat(OpenAIClient): Add HttpsProxyAgent to initializeLLM (danny-avila#1119)

    * feat(OpenAIClient): Add HttpsProxyAgent to initializeLLM

    * chore: fix linting error in ModelService

commit 7b30ab3
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Sun Oct 29 12:23:25 2023 -0400

    docs: Add LibreChat reverse proxy setup with Basic Auth & Misc section (danny-avila#1118)

commit 2017ec5
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Sun Oct 29 11:52:31 2023 -0400

    docs: Update installation instructions for Docker and (danny-avila#1117)

    local (npm) on Linux, macOS, and Windows

commit c878289
Author: Marco Beretta <81851188+Berry-13@users.noreply.github.com>
Date:   Sun Oct 29 15:56:21 2023 +0100

    docs: fix typo "nginx" (danny-avila#1116)

    * Update linode.md

    * Update cloudflare.md

commit 5cafe09
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Fri Oct 27 17:10:07 2023 -0400

    feat(client): Toast Provider to show Toasts from higher on the DOM tree (danny-avila#1110)

commit 81a90d2
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Fri Oct 27 15:48:05 2023 -0400

    feat(Toast): add Toast nearly identical to ChatGPT's (danny-avila#1108)

commit ba5ab86
Author: Walber Cardoso <50842245+walbercardoso@users.noreply.github.com>
Date:   Thu Oct 26 22:18:03 2023 -0300

    Update ModelService.js (danny-avila#1105)

    Failed to fetch models from OpenAI API when set OPENROUTER_API_KEY on .env file

commit 11dd3b4
Author: Super12138 <70494801+Super12138@users.noreply.github.com>
Date:   Wed Oct 25 08:04:44 2023 +0800

    🌐: Update Chinese translation (danny-avila#1102)

    * Update Chinese translation

    * Fix bug

commit bc39bd1
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Oct 23 21:37:21 2023 -0400

    chore: make tag workflow push only, make manual workflow from main (danny-avila#1100)

commit 05c4c7e
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Oct 23 21:08:18 2023 -0400

    feat: add CUSTOM_FOOTER env variable (danny-avila#1098)

commit 4ce585f
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Oct 23 20:31:10 2023 -0400

    chore: allow manual trigger of tag image workflow (danny-avila#1099)

commit c7bfb2a
Author: Danny Avila <110412045+danny-avila@users.noreply.github.com>
Date:   Mon Oct 23 17:48:18 2023 -0400

    hotfix(useGetEndpointsQuery): set default variable value when transforming data with select (danny-avila#1097)

commit 3d4a877
Author: liukaixiang817 <78783855+liukaixiang817@users.noreply.github.com>
Date:   Tue Oct 24 07:48:01 2023 +1000

    Update the localisation of Chinese and Traditional Chinese (danny-avila#1095)

    * Update the localization of Chinese and Traditional Chinese

    Update the localization of ""

    * 12345

    * 12345

    12345

    * Revert "12345"

    This reverts commit 70483db.

    * Revert "12345"

    This reverts commit db0f554.
Merge tag 'v0.6.1' into main
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
@danny-avila
fix: force navigation to /chat/new on endpoint change and conversatio…
bc5b8c6 
…n deletions (danny-avila#1141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danny-avila