feat: allow any reverse proxy URLs, add proxy support to model fetching #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny-avila
changed the title
|
@Airkek, let me know if this works for you. I wasn't able to test the proxying but it should work. |
1 task
seems like it doesn't work |
No, it was my fault, i set HTTPS_PROXY env var and it was overriding axios httpsAgent. All works fine |
cnkang
pushed a commit
to cnkang/LibreChat
that referenced
this pull request
Feb 6, 2024
…ng (danny-avila#1192) * feat: allow any reverse proxy URLs * feat: add proxy support to model fetching
jinzishuai
pushed a commit
to aitok-ai/LibreChat
that referenced
this pull request
May 20, 2024
…ng (danny-avila#1192) * feat: allow any reverse proxy URLs * feat: add proxy support to model fetching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously would prevent any reverse proxies, to follow the strict /v1 pattern. I don't think this is necessary anymore, as most will know they need a baseURL from their proxy, and that their api should handle all the specs as openai does.