Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix: Correct Endpoint Switching on Error Reception #1225

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

danny-avila
Copy link
Owner

🔧 fix: Correct Endpoint Switching on Error Reception

Summary

This pull request addresses an issue where the application was not properly switching endpoints and resetting the conversation if the first message received was an error. This fix ensures that the application updates the conversation state correctly with initial errors, resetting the conversation to maintain a smooth user experience. No dependencies are required for this change.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

To ensure the fix works as expected, the following test process was conducted:

  1. Simulated an error response as the first message from the server.
  2. Verified that the application detects the error and switches to the alternate endpoint.
  3. Confirmed that the conversation is reset after the switch to avoid any inconsistencies.

To reproduce these tests:

  • Configure the server to return an error response as the first message.
  • Run the application and observe the behavior to ensure that the endpoint switch and conversation reset occur without any user intervention.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit 4b28964 into main Nov 26, 2023
1 check passed
@danny-avila danny-avila deleted the fix-convo-error branch November 26, 2023 19:24
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant