Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔄 fix: Prevent Image Auto-Rotation on Upload #1250

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

danny-avila
Copy link
Owner

Summary

I've addressed an issue where uploaded images were being auto-rotated incorrectly. The underlying cause was that the auto-orientation feature wasn't considering the EXIF data of the images. With the changes, the image uploader now invokes a rotate method to correctly auto-orient the image based on its EXIF data. This fix ensures that images are displayed in the orientation they were intended to be.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

To verify the changes, upload various images with different EXIF orientation data. Ensure that the images maintain their correct orientation post-upload. Test with images taken from different devices and in various orientations (landscape, portrait, upside-down, etc.).

Test Configuration:

  • Devices: Multiple devices (phone, tablet, camera)
  • Image formats tested: JPG, PNG
  • EXIF data variations: Various orientation flags

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila merged commit 9882744 into main Nov 30, 2023
2 checks passed
@danny-avila danny-avila deleted the prevent-img-rotate branch November 30, 2023 18:59
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
jinzishuai pushed a commit to aitok-ai/LibreChat that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant