Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 style: Refine SidePanel and Textarea Styling #2209

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Mar 26, 2024

Summary

This pull request focuses on improving the styling and functionality of the SidePanel and Textarea components. The changes include:

  • Refactor SidePanel to provide more control over toggle states, add a new hide panel button, and improve toggle state logic.
  • Memoize values and improve side panel toggle states for better performance.
  • Update styling for the ScrollToBottom button.
  • Force a resize of the Textarea when the placeholder text changes to ensure proper rendering.
  • Experiment with TextareaAutosize wrapper and useLayoutEffect to address random textarea jankiness.
  • Properly offset tooltips for side panel buttons

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules

@danny-avila danny-avila merged commit 718572b into main Mar 26, 2024
1 check passed
@danny-avila danny-avila deleted the style-updates branch March 26, 2024 08:19
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
* experimental: use TextareaAutosize wrapper with useLayoutEffect to hopefully fix random textarea jankiness

* fix(Textarea): force a resize when placeholder text changes

* style(ScrollToBottom): update styling for scroll button

* style: memoize values and improve side panel toggle states

* refactor(SidePanel): more control for toggle states, new hide panel button, and improve toggle state logic

* chore: hide resizable panel handle on smaller screens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant