Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧠 fix(Cohere): map to expected SDK params #2329

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Apr 5, 2024

Summary

I missed that Cohere expects camel-case params when using Typescript SDK. Raw API/python does not.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • New documents have been locally validated with mkdocs

@danny-avila danny-avila merged commit fb80af0 into main Apr 5, 2024
2 checks passed
@danny-avila danny-avila deleted the fix-cohere branch April 5, 2024 20:45
jinzishuai pushed a commit to aitok-ai/LibreChat that referenced this pull request May 20, 2024
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant