Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 refactor: Attempt Default Preset Fix & Other Changes #2342

Merged
merged 3 commits into from
Apr 6, 2024
Merged

🚧 refactor: Attempt Default Preset Fix & Other Changes #2342

merged 3 commits into from
Apr 6, 2024

Conversation

danny-avila
Copy link
Owner

Summary

This PR is a work in progress but will merge to see if the issue highlighted in #2334 is alleviated.

Other Changes

  • fix issue to re-render submit button state on undo, to prevent empty text submission
  • show pin icon for default preset

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • New documents have been locally validated with mkdocs

@danny-avila danny-avila merged commit 334b603 into main Apr 6, 2024
1 check passed
@danny-avila danny-avila deleted the attempt-fix branch April 6, 2024 20:09
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
@danny-avila
🚧 refactor: Attempt Default Preset Fix & Other Changes (danny-avila#2342
4774950 
)

* fix(useTextarea): trigger SendButton re-render on undo and clearing text

* refactor(PresetItems): show pin icon for default preset

* fix(ChatRoute): do not use conversation.model for useEffect, do not set default Preset if real model list is not yet fetched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danny-avila