Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 feat: Enhance Message Editing with File Resubmission #2347

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Apr 7, 2024

Summary

Implemented improvements to the message editing functionality, enabling seamless resubmission of attached files when modifying messages. Additionally, refactored the image loading strategy and integrated file/image rendering within the Message Container component.

  • Introduced file resubmission logic when editing messages with attached files.
  • Refactored the image loading strategy to utilize a different lazy loading strategy.
    • Prevents dramatic resizing of placeholder
  • Consolidated image and file rendering within the Message Container component for better code organization and maintainability.

Closes #2345

Other Changes

  • Resolved type issues with the File Table fakeData, ensuring consistent data handling across the application.

Change Type

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila merged commit 3411d7a into main Apr 7, 2024
1 check passed
@danny-avila danny-avila deleted the edit-message-images branch April 7, 2024 17:25
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
)

* chore: fix type issue with File Table fakeData

* refactor: new lazy loading image strategy and load images/files as part of Message Container

* feat: resubmit files when editing messages with attached files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Attachment dissapears when editing messages
1 participant