Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 feat: Title Improvements #2363

Merged
merged 2 commits into from
Apr 9, 2024
Merged

🎨 feat: Title Improvements #2363

merged 2 commits into from
Apr 9, 2024

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Apr 9, 2024

Summary:

This change enhances the user experience by dynamically updating the document title (displayed in the browser tab) upon successful completion of the genTitle mutation. Additionally, it ensures that the generated title persists throughout the active conversation, even when additional messages are exchanged.

  • Implemented logic to update the document.title with the generated title upon successful completion of the gentitle mutation.
  • Maintained the generated title throughout the active conversation, ensuring it remains visible in the browser tab even when new messages are sent or received for the assistants endpoint
  • Improved the overall user experience by providing a more contextual and informative browser tab title, reflecting the current conversation state.
  • Remove "New Chat" placeholders used in assistants route handling

Closes #2354

Testing:

To verify the changes, follow these steps:

Test Configuration:

  • Browser: Latest versions of Chrome, Firefox, and Safari
  • Environment: Development and Production
  1. Start a new conversation.
  2. Send a message to trigger the gentitle mutation.
  3. Observe that the browser tab title updates with the generated title upon successful completion of the mutation.
  4. Continue the conversation by sending additional messages.
  5. Ensure that the generated title persists in the browser tab throughout the active conversation.

Checklist:

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules

@danny-avila danny-avila merged commit cc71125 into main Apr 9, 2024
3 checks passed
@danny-avila danny-avila deleted the title-improvements branch April 9, 2024 18:01
jinzishuai pushed a commit to aitok-ai/LibreChat that referenced this pull request May 20, 2024
* fix(assistants): keep generated title upon continued messages in active conversation

* feat: update document.title on successful gentitle mutation
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
* fix(assistants): keep generated title upon continued messages in active conversation

* feat: update document.title on successful gentitle mutation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Title Changing to "New Chat" in Assistant Mode After Second Question
1 participant