Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 fix: Minor Fixes and Refactors #2388

Merged
merged 5 commits into from
Apr 11, 2024
Merged

👷 fix: Minor Fixes and Refactors #2388

merged 5 commits into from
Apr 11, 2024

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Apr 11, 2024 •
edited
Loading

Summary

  • Fix failing tests for code not yet introduced to project
  • Implemented intended styling and behavior for the SidePanel component when non-user provided keys are used, ensuring proper handling of such cases.
  • Refactored the useTextarea hook to prioritize the disabled message when a key is not provided, instead of showing "Select Assistant" text
  • style: update combobox styling as before, with better dynamic height

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules

@danny-avila danny-avila changed the title 🪰 fix: Minor Fixes and Refactors 👷 fix: Minor Fixes and Refactors Apr 11, 2024
@danny-avila danny-avila merged commit c19dfdd into main Apr 11, 2024
1 check passed
@danny-avila danny-avila deleted the minor-fixes branch April 11, 2024 06:12
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
@danny-avila
👷 fix: Minor Fixes and Refactors (danny-avila#2388)
d64072f 
* refactor(useTextarea): set Textarea disabled message due to key higher in priority

* fix(SidePanel): intended behavior for non-user provided keys

* fix: generate specs

* style: update combobox styling as before, with better dynamic height

* chore: remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danny-avila