🐋 ci: create smaller Docker images #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create fewer layers - install only prod dependencies for final build - clean npm cache - fix layering in multi-image build
derkoe
force-pushed
the
ci/smaller-docker-image
branch
from
86d7802 to
076ae67
Compare
|
Great, thank you! I will merge this and test the resulting images |
danny-avila
approved these changes
May 13, 2024
|
so far so good 👍 |
danny-avila
pushed a commit
that referenced
this pull request
Aug 5, 2024
- create fewer layers - install only prod dependencies for final build - clean npm cache - fix layering in multi-image build
kenshinsamue
pushed a commit
to intelequia/LibreChat
that referenced
this pull request
Sep 17, 2024
- create fewer layers - install only prod dependencies for final build - clean npm cache - fix layering in multi-image build
BertKiv
pushed a commit
to BertKiv/LibreChat
that referenced
this pull request
Dec 10, 2024
- create fewer layers - install only prod dependencies for final build - clean npm cache - fix layering in multi-image build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change reduces the size of the built Docker images significantly by removing the npm dev dependencies and the npm cache.
It also removes the workarounds for the broken ARM builds. This allows to use Node 20 for the main Docker build (as it is already with the Dockerfile.multi build). It seems with node:20-alpine and the flags set the build is pretty stable (also on ARM).
Changes of Docker image sizes:
Uncompressed images sizes:
Change Type
Docker build change - the rest of the code is not affected (not sure what to choose from the PR template list).
Testing
Checklist
Please delete any irrelevant options.