Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔡 fix: Rendering of Bidirectional Text #3195

Merged

Conversation

GhaithAlHallak8
Copy link
Contributor

Summary

This basically adds bidirectional text support for key components across the UI, addressing an issue where mixing a RTL (Right-to-Left) language with a LTR (Left-to-Right) language in the same input renders the text unreadable.

Before the fix:
image
image

After:
image
image

For readers of both RTL and LTR languages, this fix significantly improves text readability.

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Translation update

Testing

N/A

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

The fix has been applied only to key components where the rendering issue is significant
@GhaithAlHallak8 GhaithAlHallak8 changed the title Fix rendering of bidirectional text in key components fix: rendering of bidirectional text Jun 26, 2024
@danny-avila danny-avila changed the title fix: rendering of bidirectional text 🔡 fix: Rendering of Bidirectional Text Jun 27, 2024
@danny-avila danny-avila merged commit 81292bb into danny-avila:main Jun 27, 2024
2 checks passed
@GhaithAlHallak8 GhaithAlHallak8 deleted the fix/bidirectional-render branch June 28, 2024 02:26
trananhhh pushed a commit to trananhhh/logos-gpt that referenced this pull request Jul 9, 2024
The fix has been applied only to key components where the rendering issue is significant
danny-avila pushed a commit that referenced this pull request Aug 5, 2024
The fix has been applied only to key components where the rendering issue is significant
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
The fix has been applied only to key components where the rendering issue is significant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants