📱 fix: Resolve Android Device and Accessibility Issues of Sidebar Combobox #3689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main issue being addressed was a symptom of the stale issue with radix-ui select: radix-ui/primitives#1658
Rather than applying hacky fixes, use of radix-select was abandoned in favor of a more accessible combobox, as it also had a11y issues.
ControlCombobox
) with improved a11y and Android device functionalityOther Changes
abortScroll
state to false after invokingscrollToEnd
Testing
To test these changes:
Test Configuration: