🔐 refactor: Unverified User Verification Logic #4482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I implemented changes to refine the user verification logic, particularly focusing on the handling of unverified emails and user expiration. These modifications enhance the flexibility of our authentication system while maintaining security measures.
AuthService.js
to disable user TTL (Time To Live) when unverified emails are allowed, while still issuing verification emails if email services are enabled.registerUser
function to consider theALLOW_UNVERIFIED_EMAIL_LOGIN
environment variable when setting the TTL.localStrategy.js
to remove theexpiresAt
field from existing users if unverified emails are now allowed, ensuring consistency with the new logic.localStrategy.js
to align with the updated unverified email allowance setting.Testing
To test these changes:
ALLOW_UNVERIFIED_EMAIL_LOGIN
environment variable.expiresAt
field is removed when logging in if unverified emails are now allowed.Test Configuration:
ALLOW_UNVERIFIED_EMAIL_LOGIN
between true and falseChecklist