Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛡️ feat: Add Role Dropdown to Prompt/Agents Admin Settings #4922

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

danny-avila
Copy link
Owner

Summary

I enhanced permission management by adding a role selection dropdown to AdminSettings for both Prompts and Agents. I also added a warning message when disabling Admin access to certain permissions, improved UI theming and layout, and updated icon colors for better clarity.

  • Add a role selection dropdown to AdminSettings for Prompts and Agents
  • Add a warning message when disabling Admin access to permissions
  • Insert a link to configuration documentation for reverting changes if Admin access is disabled
  • Reorder and refine permission toggles for improved clarity
  • Update UI theming and layouts, including icon colors and dialog accessibility

Change Type

  • New feature (non-breaking change which adds functionality)

Testing

I tested by manually verifying that the AdminSettings dialogs correctly display the role selection dropdown and that switching roles updates the permission toggles. I also tested disabling Admin access and confirmed the warning message appears. I refreshed the page to ensure UI settings persisted and followed the link to documentation to confirm it opens in a new tab.

Test Configuration:

  • Local development environment with LibreChat
  • Browser: Chrome/Firefox
  • Follow the AdminSettings dialogs to adjust roles and permissions

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit 4640e1b into main Dec 10, 2024
2 checks passed
@danny-avila danny-avila deleted the feat/role-select-perms-dialog branch December 10, 2024 00:50
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
…la#4922)

* style: update AdminSettings dialog content styles for improved accessibility/theming

* style: update icon colors in ExportAndShareMenu for improved theming

* feat: enhance DropdownPopup component with additional props for customization

* feat: add role selection dropdown to AdminSettings for enhanced user permissions management

* feat: add role selection dropdown to AdminSettings for Prompt permission management

* style: add gap to button in AdminSettings for improved layout

* feat: add warning message for Admin role access in Permissions settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant