fix: allow setting username in openIdStrategy #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed bug in setting username from openid jwt token
danny-avila
approved these changes
Aug 3, 2023
|
Thank you! Looks related to #686 and had to do a double-take to make sure which line got changed, since I remember seeing this before. |
danny-avila
changed the title
|
Does it need a ; at the end of the line instead of a , ? |
|
yes, you are correct, I will update the pull request |
fix: changed , to ; at end of line
cnkang
pushed a commit
to cnkang/LibreChat
that referenced
this pull request
Feb 6, 2024
* fixed bug in setting username from openid jwt token * bugfix - changed , to ; at end of line
jinzishuai
pushed a commit
to aitok-ai/LibreChat
that referenced
this pull request
May 20, 2024
* fixed bug in setting username from openid jwt token * bugfix - changed , to ; at end of line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug when setting username in openIdStrategy.
Instead of firstname we have to set username for existing user, the way as we do for new user.
Type of change
Please delete options that are not relevant.