Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vite warning resolutions #779

Merged
merged 5 commits into from
Aug 9, 2023
Merged

chore: vite warning resolutions #779

merged 5 commits into from
Aug 9, 2023

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Aug 9, 2023

Summary

This PR includes several chore updates and fixes:

  • Updated @vitejs/plugin-react to version 4.0.4. and Updated vite to version 4.4.9.
  • Updated vite.config.ts to resolve fonts and updated styles.css accordingly.
  • Removed artifacts related to next.js ("use client") from UI primitives, which resolves vite warnings
  • Fixed a type error in the onClick event handler of Slider.tsx.
  • also fixed condition for playwright workflow to trigger on PRs from main repo (where secrets are accessible)

Font resolution fix was discussed in this StackOverflow thread and applied it. Several UI primitives had 'use client'; their respective warnings have been resolved by removing them. Lastly, there's a similar issue with tanstack/query, as discussed in this GitHub issue. There was hope that the latest versions of vite-plugin-react and vite would resolve this, but it remains an ongoing issue for that plugin library, so the warnings persist until their libraries address the underlying issue.

Change Type

  • Chore
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

fix(Slider.tsx): fix type error in onClick event handler
…irectory

chore(vite.config.ts): import the resolve function from the path module
chore(client): update vite to version 4.4.9
…ll requests

The condition for running Playwright tests on pull requests was not properly formatted. The repository name was not enclosed in quotes. This commit fixes the condition by adding single quotes around the repository name.
@danny-avila danny-avila merged commit bdccadb into main Aug 9, 2023
2 checks passed
@danny-avila danny-avila deleted the resolve-fonts branch August 9, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant