This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
Bugfix/navigation to other page fix #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
suggested changes
Mar 4, 2020
Changed how we set the currentPage variable as per @dansiegel's recommendation
|
Hey @dansiegel, is there anything else that needs to be done or is pending for this to be merged? If so, please tell me so I can move this PR along. |
|
sorry for the delay I'll take a look at this later today |
|
No problem, do it whenever you have time, please. I was just thinking it shouldn't be forgotten if it does, in fact, fix the issue. |
dansiegel
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #106
Fix is to reset the
currentPagevariable to the current MainPage after popping the PopupNavigationStack. Not tested very extensively, but seems to get the job done.Tested on iOS and Android, added a sample for testing this navigation.