Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumping cursor problem in SearchBar #443

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented May 4, 2023

Link to issue

https://reload.atlassian.net/browse/DDFSOEG-483

Description

This pull request aims to address the challenges with cursor placement in Downshift, using an approach inspired by a discussion on GitHub. The changes implemented in this PR help to improve the user experience by providing more accurate and intuitive cursor placement behavior during input interactions.

downshift-js/downshift#1108 (comment)

Screenshot of the result

Skaermoptagelse.2023-05-04.kl.12.40.20.mov

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

Additional comments or questions

As I understand it, there are some challenges with cursor placement in downshift. This is a way to handle it inspired from:

downshift-js/downshift#1108 (comment)
Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Lovely work, and great research.

@spaceo spaceo self-requested a review May 11, 2023 09:09
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

@kasperbirch1 kasperbirch1 merged commit d377456 into danskernesdigitalebibliotek:develop May 11, 2023
@kasperbirch1 kasperbirch1 deleted the DDFSOEG-483-cursoren-hopper-til-slutningen-af-sogestrengen branch May 11, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants