-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCX-PDF Conversion #40
Conversation
b638aaa
to
73ae8f2
Compare
…me types as they can differ from the know extensions
…he file interface
… have more up to date image
…n on at the time to convert pdf to docx
5fc7f44
to
26e9a91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a visual check of the code, looks good. Not so good that you have to add libreoffice just to support this.
Libreoffice was the only Open Source option available. The other one was unidoc which is not Open Source. |
001388d
to
880797b
Compare
DOCX-PDF
Description
This PR introduces the DOCX-PDF conversion and that means that is possible to convert PDF files to DOCX and the otherwise is also true.
This one was though, because there's no easy way to do this by just using Go or OSS, the best solution out there was using UniDOC but it's proprietary software.
So looking around, I found out that how other projects worked around this limitation, it's basically calling
libreoffice
. Go's standard library provides a package called os/exec which allows us to runs external commands and that's what I needed to work with libreoffice.DOCX -> PDF
PDF -> DOCX
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
QA'd this change locally with multiple files and I added more tests.
Checklist: