Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unipdf #46

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Replace unipdf #46

merged 2 commits into from
Apr 12, 2024

Conversation

danvergara
Copy link
Owner

@danvergara danvergara commented Apr 3, 2024

Replace unipdf with go-fitz

Description

As a user suggested, it seems that go-fitz is a better fit for morphos than unipdf is. I wanted to removed unipdf because of the license of the project, which is more like a product than a FOSS project.

/upload HTTP handler execution time using Unipdf:

Screenshot from 2024-04-03 21-51-01

/upload HTTP handler execution time using go-fitz:

Screenshot from 2024-04-03 21-53-15

Testing with a 60 pages PDF file, running the container on Linux (Fedora).

OS Name: Fedora
Version: 39
Processor: Intel i7-8650U (8) @ 4.200GHz
Installed Physical Memory (RAM) 24.0 GB

Fixes #45

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran the test suite and QA'd this to make sure the replacement works as expected.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara added enhancement New feature or request file:image Feature or bugfix that has to do with images file:document Feature or bugfix that has to do with documents labels Apr 3, 2024
@danvergara danvergara requested review from rdleon and Arturomtz8 April 3, 2024 23:51
@danvergara danvergara self-assigned this Apr 3, 2024
@danvergara danvergara merged commit 617d78c into main Apr 12, 2024
@danvergara danvergara deleted the replace-unipdf branch April 12, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request file:document Feature or bugfix that has to do with documents file:image Feature or bugfix that has to do with images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants