Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing licence for some tests with ©/ARR remark #1024

Closed
mirabilos opened this issue Sep 11, 2022 · 8 comments · Fixed by #1029
Closed

missing licence for some tests with ©/ARR remark #1024

mirabilos opened this issue Sep 11, 2022 · 8 comments · Fixed by #1029

Comments

@mirabilos
Copy link
Collaborator

The following files have an explicit copyright statement but no licence:

  • auto_tests/tests/PixelSampler.js
  • auto_tests/tests/css.js
  • auto_tests/tests/custom_bars.js
  • auto_tests/tests/range_selector.js
  • auto_tests/tests/selection.js
  • auto_tests/tests/update_options.js

This normally means they are unredistributable even.

For the other tests without an explicit licence statement, they also do not have a copyright statement of their own, and so the project-wide MIT licence applies.

Best fix would be adding the MIT licence to these files as well iff their copyright holder agrees (that’s Google, Inc. for all of these) or even better removal of these explicit copyright statements, given Google’s listed elsewhere already and these are just tests, but that definitely needs permission from them.

mirabilos added a commit to mirabilos/dygraphs that referenced this issue Sep 11, 2022
@mirabilos
Copy link
Collaborator Author

@danvk @paulfelix @clocksmith could you please look at these files and clarify their licence?

@danvk
Copy link
Owner

danvk commented Oct 13, 2022

Hi @mirabilos -- thanks for the PRs and issues. As you may have noticed (#727) dygraphs hasn't seen much active development recently. If you'd be interested in becoming an owner, please let me know!

@mirabilos
Copy link
Collaborator Author

mirabilos commented Oct 13, 2022 via email

@paulfelix
Copy link
Contributor

The files are all test files. Can someone just add the MIT license to them? That's certainly my wish for any file I authored.

@mirabilos
Copy link
Collaborator Author

mirabilos commented Oct 13, 2022 via email

mirabilos added a commit to mirabilos/dygraphs that referenced this issue Oct 13, 2022
@mirabilos
Copy link
Collaborator Author

Any progress on this? This is impeding anyone wanting to become an “owner” as well, because only the original licensors can add a licence statement (or instruct others to do so as Paul did).

@danvk
Copy link
Owner

danvk commented Oct 20, 2022

@mirabilos I added an explicit MIT license to each of the test files you mentioned. Hopefully this resolves the issue.

@mirabilos
Copy link
Collaborator Author

mirabilos commented Oct 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants