There's 365.2425 days in a gregorian year #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing! The truth will eventually come out? Nice to know that dygraphs has had influence, even if it's been spreading misinformation :) |
andrewrondeau-optirtc
added a commit
to OptiRTC/dygraphs
that referenced
this pull request
Nov 17, 2021
There are 365.2425 days in a gregorian year, not 365.2524 (danvk#1012)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was idly searching github for bugs and found that many references to the constant 365.2524 originate from this library. The actual constant is 365.2425. It doesn't really matter at all, but I thought it would be nice to correct it.