Resize handler #200
Merged
Resize handler #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vents private, and prevent multiple registration.
| @@ -995,9 +999,14 @@ Dygraph.prototype.destroy = function() { | |||
| this.registeredEvents_ = []; | |||
|
|
|||
| // remove mouse event handlers (This may not be necessary anymore) | |||
| Dygraph.removeEvent(this.mouseEventElement_, 'mouseout', this.mouseOutHandler); | |||
| Dygraph.removeEvent(this.mouseEventElement_, 'mousemove', this.mouseMoveHandler); | |||
There was a problem hiding this comment.
do you need to add a null check to Dygraph.removeEvent()?
There was a problem hiding this comment.
I don't think so. From mozilla: Prior to Firefox 6, the browser would throw if the useCapture parameter was not explicitly false. Prior to Gecko 9.0 (Firefox 9.0 / Thunderbird 9.0 / SeaMonkey 2.6), addEventListener() would throw an exception if the listener parameter was null; now the method returns without error, but without doing anything.
I think addEventListener is a typo, meant removeEventListener. Could break someone, but TBH, the odds of those being null when the object is destroyed are low (oh perhaps with a URL fetch that never returns or something.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.