Fixed computation of stacked series in case some series start in the mid... #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is one I'm going to leave to @danvk. Thanks for writing the test! |
…middle of the range The bug is caused by stale value of last_x local across loop in gatherDatasets_. See https://code.google.com/p/dygraphs/issues/detail?id=438
|
Rebased against current master as the changes in stacked.js produce merge conflicts with #225 |
danvk
added a commit
that referenced
this pull request
Mar 2, 2013
Fixed computation of stacked series in case some series start in the mid...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...dle of the range
The bug is caused by stale value of last_x local across loop in gatherDatasets_.
See https://code.google.com/p/dygraphs/issues/detail?id=438
Added test for the bug. All tests pass.
lint.sh reveals no new warnings