-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinch zoom ux #991
base: master
Are you sure you want to change the base?
Pinch zoom ux #991
Conversation
…w ups in the zoom in/out).
…arget.getBoundingClientRect()
…eally well on mobile touch devices, good job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a recommended procedure to test this? An example page, or just the one on https://dygraphs.com/ and then pinching around, or something better than that?
} | ||
|
||
if (Math.abs(initHalfHeight) > minAllowed) { | ||
var damp = 1 / (Math.abs(initHalfHeight) - minAllowed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT var
has function scope, so this is an error. I’d say declare var damp
above with the initHalf{Width,Height}
and reuse it in both branches.
// ex is a tuple [a, b], with a <= b | ||
function isOutOfExtremes(p, ex) { | ||
|
||
return p < ex[0] || p > ex[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do add explicit semicola at the end of instructions (not just here but everywhere); semicolon insertion is considered harmful
Try numericnews I am sorry, but 5 years later I do not find much time to give additional support. |
This pull request is an experimentation on improving the UX of pinch-zoom.
It starts from pull request 990, which fixes two functional bugs, and it adds the following: