Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add expression evaluation back to REPL #18

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Conversation

danvk
Copy link
Owner

@danvk danvk commented Jan 17, 2024

This is chapter 8 challenge 1. This is a case where using a class for the parser would be helpful, since it would be easier to make both the parse and expression methods public.

I'm following the Node readline tiny CLI example: https://nodejs.org/api/readline.html#example-tiny-cli

It's nice to have up arrow in the CLI, but there's definitely a flicker that I don't love.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d610476) 96.18% compared to head (97aabdc) 96.33%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/main.ts 78.72% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   96.18%   96.33%   +0.15%     
==========================================
  Files          11       11              
  Lines         995     1036      +41     
  Branches      147      155       +8     
==========================================
+ Hits          957      998      +41     
  Misses         37       37              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danvk danvk merged commit c4279f6 into main Jan 19, 2024
14 checks passed
@danvk danvk deleted the chapter8-repl-expr branch January 19, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant