chore: Refactor to make Interpreter not be a visitor #35
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 97.74% 97.35% -0.39%
==========================================
Files 17 17
Lines 1947 1925 -22
Branches 291 317 +26
==========================================
- Hits 1903 1874 -29
- Misses 43 50 +7
Partials 1 1 ☔ View full report in Codecov by Sentry. |
After puzzling over the visitor pattern in TypeScript, @mulias pointed out that I didn't really need it; pattern matching (via a switch statement) is the more idiomatic way to do this with a tagged union.
This is that refactor. There's a lot fewer imports, at least. No visitor but we still get exhaustiveness checking. For the
evaluatemethod it's via the implicit return. For theexecutemethod on expressions, we have to bake it in more explicitly.