Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some more tests to scanner #4

Merged
merged 7 commits into from
Jan 9, 2024
Merged

chore: add some more tests to scanner #4

merged 7 commits into from
Jan 9, 2024

Conversation

danvk
Copy link
Owner

@danvk danvk commented Jan 9, 2024

I played around with making this less class-based, but really it's not that much different. Just dropping this and replacing all the methods with closures. (Stashed in the functional-scanner on my laptop.)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed5c79a) 74.92% compared to head (5b022a1) 83.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   74.92%   83.08%   +8.15%     
==========================================
  Files           5        5              
  Lines         331      331              
  Branches       39       45       +6     
==========================================
+ Hits          248      275      +27     
+ Misses         82       55      -27     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danvk danvk changed the title chore: add some more tests to scanner, rework to be less OOPy chore: add some more tests to scanner Jan 9, 2024
@danvk danvk merged commit d0213a1 into main Jan 9, 2024
16 checks passed
@danvk danvk deleted the chapter4-followup branch January 9, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant