Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Chapter 6, Parsing Expressions #8

Merged
merged 8 commits into from
Jan 11, 2024
Merged

feat: Implement Chapter 6, Parsing Expressions #8

merged 8 commits into from
Jan 11, 2024

Conversation

danvk
Copy link
Owner

@danvk danvk commented Jan 11, 2024

Implementation of Chapter 6: Parsing Expressions.

I mostly followed the book implementation, except that I didn't use a class this time.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (2fb673d) 88.79% compared to head (27066d0) 87.32%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/parser.ts 86.30% 23 Missing ⚠️
src/main.ts 47.05% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   88.79%   87.32%   -1.48%     
==========================================
  Files           6        8       +2     
  Lines         366      568     +202     
  Branches       48       73      +25     
==========================================
+ Hits          325      496     +171     
- Misses         40       71      +31     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danvk danvk merged commit e0e164c into main Jan 11, 2024
12 checks passed
@danvk danvk deleted the chapter6 branch January 11, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant