Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terminate process once it completes all the work #9

Merged

Conversation

alessandromazza98
Copy link
Contributor

@alessandromazza98 alessandromazza98 commented Sep 25, 2024

With this PR, replayor gracefully shutdown once it completes all the work.

Previously the process never terminates until you hit ctrl + c. I found it better to terminate the process once it's done working instead of leaving the process running but doing nothing.

NOTE: not a super expert in Go, this works btw.

@danyalprout

@danyalprout
Copy link
Owner

Appreciate it, thank you 🙏

@danyalprout danyalprout merged commit fe7e0e4 into danyalprout:main Sep 27, 2024
2 checks passed
@alessandromazza98 alessandromazza98 deleted the ale/terminate-process branch October 3, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants