-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement table layout #365
Conversation
Demo appDeployed 3c39f4a to https://example-iht8p9ckw.vercel.app. Quick links: |
how's it going? do you need any help? |
Most of the tasks have been completed, only one is left now: (see #346 )
I hope to have some free time and finish it this weekend. |
Great Merge Request :) On my test app there was an intrinsics crash on the html content of this article, but with this branch it's working. |
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 97.97% 98.27% +0.30%
==========================================
Files 37 37
Lines 2415 2662 +247
==========================================
+ Hits 2366 2616 +250
+ Misses 49 46 -3
Continue to review full report at Codecov.
|
6806ae0
to
a44c9ad
Compare
a44c9ad
to
fc58cdb
Compare
2eed8e6
to
e7dbe8b
Compare
when the new version with fixed tables will be released? |
The checks are all green so hopefully in a few days. There are still some small details that need taken care of. |
f630034
to
8a2bdba
Compare
Cela pouver causer des ralentissements sur certains appareils. Il reste à attendre les mises à jours prochaines de flutter_widget_from_html_core (cf. daohoangson/flutter_widget_from_html#365) et de flutter_math (cf. znjameswu/flutter_math#17) avec la release.
What's the state of the table MR at the moment? We want to evaluate shortly whether we want to use this package or continue to use flutter_html for our apps. The tables are of course essential for this. |
Yes, this PR includes a new border parser which allows each table cell to has its own color.
It does the job but there are a few goals are not done yet so I'm hesitant to merge because the remaining goals may require further refactors. That said, I'll cut a new RC right away so people can give it a try. |
v0.5.2-rc.2021011801 has been released! |
Related to #346