Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement table layout #365

Merged
merged 27 commits into from
Jan 18, 2021
Merged

Re-implement table layout #365

merged 27 commits into from
Jan 18, 2021

Conversation

daohoangson
Copy link
Owner

Related to #346

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

This was referenced Nov 5, 2020
@misterfourtytwo
Copy link

how's it going? do you need any help?

@daohoangson
Copy link
Owner Author

Most of the tasks have been completed, only one is left now: (see #346 )

  • Add support for COLGROUP, COL tag

I hope to have some free time and finish it this weekend.

@DFelten
Copy link
Contributor

DFelten commented Nov 22, 2020

Great Merge Request :) On my test app there was an intrinsics crash on the html content of this article, but with this branch it's working.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #365 (3c39f4a) into master (3b54a3b) will increase coverage by 0.30%.
The diff coverage is 98.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   97.97%   98.27%   +0.30%     
==========================================
  Files          37       37              
  Lines        2415     2662     +247     
==========================================
+ Hits         2366     2616     +250     
+ Misses         49       46       -3     
Impacted Files Coverage Δ
packages/core/lib/src/core_data.dart 100.00% <ø> (ø)
packages/core/lib/src/core_helpers.dart 98.24% <ø> (ø)
packages/core/lib/src/internal/core_ops.dart 100.00% <ø> (ø)
...ages/core/lib/src/internal/ops/style_bg_color.dart 100.00% <ø> (ø)
...ckages/core/lib/src/internal/ops/style_margin.dart 100.00% <ø> (ø)
...kages/core/lib/src/internal/ops/style_padding.dart 100.00% <ø> (ø)
...es/core/lib/src/internal/ops/style_text_align.dart 100.00% <ø> (ø)
packages/core/lib/src/internal/ops/text_style.dart 100.00% <ø> (ø)
packages/enhanced/lib/src/widget_factory.dart 96.03% <ø> (-0.07%) ⬇️
packages/core/lib/src/widgets/html_table.dart 95.18% <95.18%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b54a3b...3c39f4a. Read the comment docs.

@daohoangson daohoangson self-assigned this Nov 27, 2020
@daohoangson daohoangson added this to the 0.5.2 milestone Nov 27, 2020
@misterfourtytwo
Copy link

when the new version with fixed tables will be released?

@daohoangson
Copy link
Owner Author

The checks are all green so hopefully in a few days. There are still some small details that need taken care of.

Skyost added a commit to Skyost/Bacomathiques that referenced this pull request Dec 3, 2020
Cela pouver causer des ralentissements sur certains appareils. Il reste à attendre les mises à jours prochaines de flutter_widget_from_html_core (cf. daohoangson/flutter_widget_from_html#365) et de flutter_math (cf. znjameswu/flutter_math#17) avec la release.
@DFelten
Copy link
Contributor

DFelten commented Jan 14, 2021

What's the state of the table MR at the moment? We want to evaluate shortly whether we want to use this package or continue to use flutter_html for our apps. The tables are of course essential for this.

@daohoangson
Copy link
Owner Author

Does this pull request also gives us a way to configure table borders color ?

Yes, this PR includes a new border parser which allows each table cell to has its own color.

What's the state of the table MR at the moment? We want to evaluate shortly whether we want to use this package or continue to use flutter_html for our apps. The tables are of course essential for this.

It does the job but there are a few goals are not done yet so I'm hesitant to merge because the remaining goals may require further refactors. That said, I'll cut a new RC right away so people can give it a try.

@daohoangson daohoangson merged commit e2e2897 into master Jan 18, 2021
@daohoangson daohoangson deleted the tag/table/rewrite branch January 18, 2021 15:57
@daohoangson
Copy link
Owner Author

v0.5.2-rc.2021011801 has been released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants